| View previous topic :: View next topic |
| Author |
Message |
rosc2112
Revered One
Joined: 19 Feb 2006
Posts: 1454
Location: Northeast Pennsylvania
|
 Posted: Sun May 14, 2006 10:43 pm Post subject: found a bug! |
 |
|
Damn, I'm good, I found a bug 1st try! <grin>
Using the beta version, somehow the tagline and plot are bleeding together:
| Code: |
<bot> 'Daria' (1997) - http://www.imdb.com/title/tt0118298/
<bot> Tagline : Talks Slow, Thinks Fast
<bot> Plot Outline: A smart & cynical girl goes through teenage life as an proud outsider in a world of mainly idiotic teens and condescending adults.
<bot> Genre : Animation / Comedy
<bot> Awards : N/A
<bot> Rating : 7.8/10 (25 votes)
<bot> Director: Ray Kosarin, Anthony Davis, (more)
<bot> Runtime : 22 mins.
<bot> Country : USA / South Korea
<bot> Language: English
<bot> Budget : N/A
<bot> Plot : A smart & cynical girl goes through teenage life as an proud outsider in a world of mainly idiotic teens and condescending adults.
Debug:
[bot(dcc)] [22:07] IMDB_DEBUG tagline == Talks Slow, Thinks Fast
[bot(dcc)] Plot Outline: A smart & cynical girl goes through teenage life as an proud outsider in a world of mainly idiotic teens and condescending adults.
[bot(dcc)] [22:07] IMDB_DEBUG plot == A smart & cynical girl goes through teenage life as an proud outsider in a world of mainly idiotic teens and condescending adults.
|
Hmm..tried a few other titles, didn't have that problem.. Did it for Beavis and Butthead as well.. Damn awnry cartoons. Tried with 'King Kong' same prob.. Damn anwry giant monkeys..
Also note that in the director line, a html code is sneaking through:
<bot> Director: Ray Kosarin, Anthony Davis, (more)
Should prolly chop the line at the (more)
And just a reminder request, to add the writers credits (I know, I'm a pain in the arse 
Thanks again OV2  |
|
| Back to top |
|
 |
OV2
Voice
Joined: 21 Jan 2006
Posts: 35
|
| Posted: Mon May 15, 2006 8:54 am Post subject: |
|
|
I thought I was cutting in front of "(more)" ... damn regexp...
I'll take a look when I'm home (still 2 hours of *work work*).
And yes I'll eventually get around to the writers credits  |
|
| Back to top |
|
|
OV2
Voice
Joined: 21 Jan 2006
Posts: 35
|
| Posted: Mon May 15, 2006 1:24 pm Post subject: |
|
|
OK I've fixed all reported bugs (except the tcl-special-char-safeness  ) and the writers credits should also work. Redownload the beta rar file, it should be the new version.
And feedback is always appreciated. |
|
| Back to top |
|
|
rosc2112
Revered One
Joined: 19 Feb 2006
Posts: 1454
Location: Northeast Pennsylvania
|
| Posted: Mon May 15, 2006 4:47 pm Post subject: |
|
|
This version looks excellent so far, haven't found anything to break it yet.
Just 2 notes:
On the awards, its leaving an extraneous space on the lefthand side, so I added after the regsub's:
| Code: |
set awards [string trimleft $awards]
|
And in mapfile I've added:
| Code: |
& #161; ¡
(had to put a space there cos the html code was being translated)
|
I suppose eventually I'll come across titles with other funky ascii chars, and will add them as needed
Thanks again OV2 |
|
| Back to top |
|
|
OV2
Voice
Joined: 21 Jan 2006
Posts: 35
|
| Posted: Mon May 15, 2006 5:34 pm Post subject: |
|
|
I added the trim line but used a normal trim, so that possible trailing spaces are also removed.
What do you mean with "html code was translated"? Isn't that the purpose of the mapfile? |
|
| Back to top |
|
|
rosc2112
Revered One
Joined: 19 Feb 2006
Posts: 1454
Location: Northeast Pennsylvania
|
| Posted: Mon May 15, 2006 8:09 pm Post subject: |
|
|
| OV2 wrote: |
What do you mean with "html code was translated"? Isn't that the purpose of the mapfile? |
Nono, I meant it was translated here on the board, even with the code tags.. Silly phpboards..
I found another thing to tweak: When searching for 'Martian Chronicles' and some other titles (south park for example), imdb has "rest of cast listed alphabetically:" in the cast lines, so the output shows as:
| Code: |
<bot> Joyce Van Patten .... Elma Parkhill rest of cast listed alphabetically: Linda Lou Allen .... Marilyn
|
|
|
| Back to top |
|
|
OV2
Voice
Joined: 21 Jan 2006
Posts: 35
|
| Posted: Tue May 16, 2006 5:13 pm Post subject: |
|
|
| Fixed that bug - I think it's only one changed line (simply redownload). |
|
| Back to top |
|
|
rosc2112
Revered One
Joined: 19 Feb 2006
Posts: 1454
Location: Northeast Pennsylvania
|
| Posted: Fri May 19, 2006 3:58 pm Post subject: |
|
|
Found another small prob, when my network is really screwy (blame epix  )
sometimes I'll get this in the bot's log:
Tcl error [imdb_proc]: couldn't open socket: host is unreachable
Perhaps the script can catch that and return a msg to the user that it was unable to connect.
Tnx |
|
| Back to top |
|
|
rosc2112
Revered One
Joined: 19 Feb 2006
Posts: 1454
Location: Northeast Pennsylvania
|
| Posted: Sun Jul 09, 2006 5:04 pm Post subject: |
|
|
Oh boy, found a new bug, cept I can't figure out quite how to fix it. When imdb goes directly to a movie's page, the script is returning an error about
"Tcl error [imdb_proc]: can't read "oldpage(meta)": no such variable:
This happens with the movie "invisible circus" for example.
Any ideas how to fix? =)
Tnx |
|
| Back to top |
|
|
OV2
Voice
Joined: 21 Jan 2006
Posts: 35
|
| Posted: Sun Jul 09, 2006 5:27 pm Post subject: |
|
|
| Invisible circus works find here... maybe it's got something to do with the new advertising pages that now sometimes pop up? I'll try to check that tomorrow. |
|
| Back to top |
|
|
rosc2112
Revered One
Joined: 19 Feb 2006
Posts: 1454
Location: Northeast Pennsylvania
|
| Posted: Mon Jul 10, 2006 12:16 am Post subject: |
|
|
| Meh, I found the problem, it was because I changed ::http::Finish to ::http::cleanup.. I can't find any documentation for "http::Finish" and the docs I do have indicate that "http::cleanup" is what's sposed to be used to close the connection and stuff... Why this makes a diff, I dont know =) |
|
| Back to top |
|
|
Sir_Cedric_Lex2
Voice
Joined: 03 Jul 2006
Posts: 3
|
| Posted: Mon Jul 10, 2006 5:10 pm Post subject: |
|
|
Hi OV2, script works fine...
nice to meet you here^^
great work!
cu |
|
| Back to top |
|
|
rosc2112
Revered One
Joined: 19 Feb 2006
Posts: 1454
Location: Northeast Pennsylvania
|
| Posted: Fri Jul 21, 2006 8:49 am Post subject: imdb cast format change |
|
|
Just noticed today IMDB changed the html a bit for the "Cast" listings, I made the following change in my copy of the script:
| Code: |
replaced:
#regsub -all {</tr><tr>} $cast \n cast_multiline
with:
regsub -all {</td></tr><tr bgcolor=\"#.*?\">} $cast \n cast_multiline
|
|
|
| Back to top |
|
|
MenzAgitat
Op
Joined: 04 Jul 2006
Posts: 118
Location: France
|
| Posted: Tue Jul 25, 2006 11:04 pm Post subject: |
|
|
There's a bug displaying infos about the movie "cars" :
| Quote: | <Boole> Cars (2006) - http://www.imdb.com/title/tt0317219/
<Boole> réalisateur : John Lasseter, Joe Ranft (co-director),
<Boole> ,
<Boole> Writing credits
<Boole> John Lasseter (story) &, Joe Ranft (story) ...
<Boole> genre : Animation / Comedy / Family / Fantasy / Sport
<Boole> une pensée sur ce film : Ahhh... it's got that new movie smell.
<Boole> synopsis : Cars Is the saga of Lightning McQueen, a hot-shot animated stock-car voiced by actor Owen Wilson. In route to a big race, the cocky McQueen gets waylaid in Radiator Springs, where he finds the true meaning of friendship and family.
<Boole> classement : 7.7/10 (9,517 votes) [••••••••--]
<Boole> récompenses : 2 nominations
<Boole> durée : 116mn.
<Boole> casting : Owen Wilson .... Lightning McQueen (voice)
<Boole> Paul Newman .... Doc Hudson (voice)
<Boole> Bonnie Hunt .... Sally Carrera (voice)
<Boole> Larry The Cable Guy .... Mater (voice)
<Boole> Cheech Marin .... Ramone (voice) |
The announce is displayed by :
| Code: | | set announce(IMDBIRC) "%bold%title%bold - %color12%uline%url%uline%color\n%ulineréalisateur :%uline %color14%name%color\n%ulinegenre :%uline %color14%genre%color\n%ulineune pensée sur ce film :%uline %color14%tagline%color\n%ulinesynopsis :%uline %color14%plot%color\n%ulineclassement :%uline %color14%rating (%votes votes) %rbar %color\n%ulinerécompenses :%uline %color14%awards%color\n%ulinedurée :%uline %color14%timemn.%color\n%ulinecasting :%uline %color14%castmline" |
Also, how to find infos for movies like "E.T." or "Les dessous de Clara Morgane" ? Typing the exact right name can be difficult... Would it be possible to take automatically the first of the several suggested matches in case several movie names fit ?
In case the bot can't find infos about a given search argument, he says : <Boole> No no no! I can't find that! and it increases the flood control count. Shouldn't unsuccessful searches be excluded from the flood control ?
When searching for a movie, In case the result points towards an actor instead of a movie, all fields are filled by N/A. Could you add a specific error message to handle this ?
Example with !imdb Clara Morgane :
| Quote: | <Boole> N/A - http://www.imdb.com/
<Boole> réalisateur : N/A
<Boole> genre : N/A
<Boole> une pensée sur ce film : N/A
<Boole> synopsis : N/A
<Boole> classement : N/A (N/A votes)
<Boole> récompenses : N/A
<Boole> durée : N/Amn.
<Boole> casting : N/A |
Keep up the good work |
|
| Back to top |
|
|
rosc2112
Revered One
Joined: 19 Feb 2006
Posts: 1454
Location: Northeast Pennsylvania
|
| Posted: Wed Jul 26, 2006 12:25 am Post subject: |
|
|
1) The problem with the commas in the director output, I fixed by using:
| Code: |
set name [string map {<br> "\ "} $name]
instead of
set name [string map {<br> ", "} $name]
|
2) Searching for "ET the extraterrestrial" works.
3) The script does already take the 1st match when there are multiple possible matches.
4) Dessous de Clara Morgane doesn't work because the only listing IMDB does have for it, is under "Actress Filmography" which is not a string that the script looks for. Prolly easy enough to add in, although not something I feel compelled to do myself.
5) Unsuccessful matches *should* increase the flood control count, in case some idiot decides to flood the bot with garbage. And since this is a configurable option, you can disable it if you want.
6) I use this at the end of the script, at the end of "output results"
| Code: |
last line of output -> set output [replacevar $output "%wcredits" $wcredits]
foreach line [split $output "\n"] {
if {[regexp N/A $line]} {
continue
} else {
puthelp "$toput :$line"
}
}
|
|
|
| Back to top |
|
|
|
FAQ
Search
Memberlist
Usergroups
Register
Profile
Log in to check your private messages
Log in
