egghelp.org community

[BeBoo]

Hey everyone. I am making a simple exec tcl script that only I can run with my eggie that will do little commands on my shell for me instead of logging into it to do a simple task. Anyway, my problem is, I can get it to run single word commands such as "uptime" and "pwd" but i can't get it to do anything that has a switch needed such as "ps -x". I get the following error:

[CrazyCat]

without the quotes?
I've tried in PL: .tcl exec ps -ux

It works, making a lot off errors because it tries to execute the output.
_________________
https://www.eggdrop.fr - French IRC network
Offer me a coffee - Do not ask me help in PM, we are a community.

[BeBoo]

Without what quotes? I typed: !exec ps -u (with no quotes)

I get the following with the .tcl command in PL:

[nml375]

First off, try to avoid using the name "args" for any variable, unless explicitly intended to use it's special feature.
Secondly, you'll have to separate the arguments from the command in the cmd-line string, and pass them as a separate argument to exec.

A simple example:

[BeBoo]

I am using it's feature... It's in my proc... proc runit {nick uhost handle chan args} {

That works great! Now, because the commands that I will run, most of them are multi-lined and would like all the lines to appear in the output. How would I determine the end of the line? Would it be \n?

Thanks!!!

[nml375]

So you use several different types of bindings to trigger that proc?

Ah well, newlines would generally be \n yes, possibly except on "odd" (windows) platforms...
_________________
NML_375, idling at #eggdrop@IrcNET

[BeBoo]

Just one binding: !exec

I will post my script so it can be critiqued when I'm done cleaning it up.

heh

[nml375]

Then, pardon me for asking, what use would you have of using "args"?
_________________
NML_375, idling at #eggdrop@IrcNET

[BeBoo]

Because I call the commands I want to be exec'd... for instance:

!exec ps -u
or
!exec uptime

[nml375]

So?
Still only gets passed to the proc as a single parameter... Hence you get the whole commandline when doing [lindex $args 0].

in fact, you'd get the same result if you'd replace "args" with "text", and "[lindex $args 0]" with "$text" in your script
_________________
NML_375, idling at #eggdrop@IrcNET

[BeBoo]

Thanks. I've made that change.

One other question... If I were to run a command such as 'who' by !exec who (which is not allowed on the shell), it outputs the "Permission denied" as a TCL error in the PL... Is there a way to detect if it's an error of some sort and have it output it to the channel anyway?

Thanks!

[nml375]

Try something like this then:

[rosc2112]

Scripts that run exec, especially with unchecked input, are dangerous. Something to keep in mind when writing this script.
Script security