egghelp.org community

[mcdarby]

Hi, I have been working on a TCL Script for an eggdrop bot v1.6.18 for a while now and seemed okay. It is a script that I made to have the bot temporary ban and kick users that post URL links to fraudulent websites, which is this.

[nml375]

Just to double-check, could you paste the output from ".binds pubm"? (in dcc)
_________________
NML_375, idling at #eggdrop@IrcNET

[mcdarby]

[nml375]

Seems the only one triggered was this one:

[mcdarby]

[rosc2112]

add either 'global badurlexempts' to the top of your proc, or use the variable notation $::badurlexempts within the proc. It's not finding the var cos its outside the proc, its in global space.

eg, do either:

proc badurl {nick uhost hand chan text} {
global badurlexempts
foreach text $badurlexempts {


OR use:

proc badurl {nick uhost hand chan text} {
foreach text $::badurlexempts {

[mcdarby]

[TCL_no_TK]

Its not showing the text becouse you are setting text as something else when you do

[mcdarby]

[nml375]

The problem here, is that you iterate through the whole list of exemts, and kick on all items not matching, and exempting on those that do match.

You'll have to wait with the kicking until you've gone through the whole list, keeping some kind of match/no-match-sofar variable within the loop - and once the foreach-loop completes, test this variable to see wether you should kick or not.
_________________
NML_375, idling at #eggdrop@IrcNET

[mcdarby]

[nml375]

Then let me walk through what actually happens:
1. Someone triggers the badurl proc (using "http://www.testtest.test.br")
2. We start our foreach loop
3. banurlexempt is "://testtest.br", which is matched against the string written by the user, in this case it's not a match. We branch off to the second branch of the conditional.
4. This is executed:

[mcdarby]

[nml375]

As stated before, it does'nt have to be that much more difficult, don't do the kicking within the loop, but after it has completed. Keep some status-variable to indicate wether there was a matching exempt, and test that variable once the loop completes to see wether you should kick or not...

A rough example in "psuedo-code"