egghelp.org community :: View topic

[ egghelp.org home | forum home ]

egghelp.org community
Discussion of eggdrop bots, shell accounts and tcl scripts.

FAQ

Memberlist

Usergroups

Profile

Spam
Goto page 1, 2, 3 Next

egghelp.org community Forum Index -> Scripting Help

View previous topic :: View next topic

Author

Message

asdd1
Voice

Joined: 05 Jul 2008
Posts: 23

Posted: Sat Jul 05, 2008 6:33 am Post subject: Spam

as Last edited by asdd1 on Sat Jul 05, 2008 1:40 pm; edited 1 time in total

Sir_Fz
Revered One

Joined: 27 Apr 2003
Posts: 3793
Location: Lebanon

Posted: Sat Jul 05, 2008 9:36 am Post subject:

Try replacing the || with && at this line

Code:

if {![isop $nick $pvchan2] || ![isvoice $nick $pvchan2]} {

and this line

Code:

if {![ischanban $pvmask2 $pvchan2] || [botisop $pvchan2]} {

_________________
Follow me on GitHub

- Opposing

Public Tcl scripts

asdd1
Voice

Joined: 05 Jul 2008
Posts: 23

Posted: Sat Jul 05, 2008 11:19 am Post subject:

No changes ;( It's same doesn't detect.

nml375
Revered One

Joined: 04 Aug 2006
Posts: 2857

Posted: Sat Jul 05, 2008 11:29 am Post subject:

Think you could show a live example of when it did not detect the spam? _________________ NML_375, idling at #eggdrop@IrcNET

speechles
Revered One

Joined: 26 Aug 2006
Posts: 1398
Location: emerald triangle, california (coastal redwoods)

Posted: Sat Jul 05, 2008 11:36 am Post subject:

Code:

if {[regexp -nocase "#" $text] || [regexp -nocase "join" $text] || [regexp -nocase "channel" $text] || [regexp -nocase "klik" $text] || [regexp -nocase "www" $text] || [regexp -nocase "pussy" $text] || [regexp -nocase "http" $text] || [regexp -nocase "server" $text] || [regexp -nocase "click" $text] > 0} {

Here is your problem, and it isn't those or's (||) this time. It's the fact you have that greater than sign and a 0 on the end. Matter of fact, why do you use regexp to do this? Why not a simple lsearch, it would save you time, and the bot wouldn't need to cycle through all those regexp's.

Code:

#Antispam With cycle command

# -> bantime
set bantime 30

# -> banned words
set bannedwords "# join channel klik www pussy http"

# -> minutes bot should cycle channels
set timecycle 1

# SCRIPT BEGINS
bind msgm - "*" pv_kick2

# kick
proc pv_kick2 {nick uhost hand text} {
foreach word [split $text] {
   if {[lsearch -exact [split [$::bannedwords]] $word}{
      set banthisguy 1
   }
}
if {[info exists $banthisguy]} {
   foreach pvchan2 [channels] {
   if {![isop $nick $pvchan2] && ![isvoice $nick $pvchan2] && [onchan $nick $pvchan2]} {
      set pvmask2 "*!*$uhost"
      if {![ischanban $pvmask2 $pvchan2] && [botisop $pvchan2]} {
         set pvkickmsg2 "\002Msg Spam 30min. Ban!"
         putquick "kick $pvchan2 $nick :$pvkickmsg2"
         putquick "mode $pvchan2 +b $pvmask2 $::bantime"

      }
   }
}
}

# cycle
timer $timecycle part_chan
proc part_chan {} {
global timecycle
foreach chancycle [channels] {
   putserv "PART $chancycle :\037Spam Check!\037"
}
timer $timecycle part_chan
}
# SCRIPT ENDS

This should work better for ya Wink

_________________
speechles' eggdrop tcl archive

Last edited by speechles on Sat Jul 05, 2008 11:51 am; edited 1 time in total

asdd1
Voice

Joined: 05 Jul 2008
Posts: 23

Posted: Sat Jul 05, 2008 11:42 am Post subject:

as Last edited by asdd1 on Sat Jul 05, 2008 1:41 pm; edited 1 time in total

nml375
Revered One

Joined: 04 Aug 2006
Posts: 2857

Posted: Sat Jul 05, 2008 11:43 am Post subject:

speechles wrote:

Code:

Although this would appear somewhat misleading, it is not causing the script to fail. The simple form of regexp returns 1 for a match, and 0 for no match. In tcl, 1 is true while 0 is false, hence "[regexp pattern string]" and "[regexp pattern string] > 0" has the same logics-table. Hence either works...

I do agree that regexp is overkill here, string match would make a far better replacement. I'm not so sure lsearch would be an option however...

Edit:
Oh, and how on earth do you expect "if {[lsearch -exact [split [$::bannedwords]] $text]}{" to work? Remember that $text would be the pattern here, and -exact implies there must be an exact match of $text and one of the words in $::bannedwords. Unless the spam is a single word, this test would miss it.
_________________
NML_375, idling at #eggdrop@IrcNET

Last edited by nml375 on Sat Jul 05, 2008 11:50 am; edited 1 time in total

speechles
Revered One

Joined: 26 Aug 2006
Posts: 1398
Location: emerald triangle, california (coastal redwoods)

Posted: Sat Jul 05, 2008 11:48 am Post subject:

nml375 wrote:

But if we compound those or's and then provide a single evaluation of greater than comparing to zero. Wont the interpreter instead, do as every other language would, and using a binary-OR operation on each of the results, which is basically an x0r... 1 to 0 to 1 to 0 to 1 to 0 to 1 to 0 and then is it greater than 0? no it equals it. This is how many programming languages behave without strict use of parenthesis to stop it.

Quote:

* Parts: gather-lv (~gather@62.84.24.156) (Spam Check!)
* Joins: gather-lv (~gather@62.84.24.156)
* ChanServ sets mode: +o gather-lv

Here is your problem. The bot is not getting opped fast enough. It is spammed before it is opped. It will not do anything when spammed if not opped.
_________________
speechles' eggdrop tcl archive

asdd1
Voice

Joined: 05 Jul 2008
Posts: 23

Posted: Sat Jul 05, 2008 11:50 am Post subject:

asd Last edited by asdd1 on Sat Jul 05, 2008 1:41 pm; edited 1 time in total

speechles
Revered One

Joined: 26 Aug 2006
Posts: 1398
Location: emerald triangle, california (coastal redwoods)

Posted: Sat Jul 05, 2008 11:58 am Post subject:

Code:

#Antispam With cycle command

# -> bantime
set bantime 30

# -> banned words
set bannedwords "# join channel klik www pussy http"

# -> minutes bot should cycle channels
set timecycle 1

# SCRIPT BEGINS
bind msgm - "*" pv_kick2

# kick
proc pv_kick2 {nick uhost hand text} {
foreach word [split $text] {
if {[lsearch -nocase -exact [split [$::bannedwords]] $word]}{
set banthisguy 1
}
}
if {[info exists $banthisguy]} {
foreach pvchan2 [channels] {
if {![isop $nick $pvchan2] && ![isvoice $nick $pvchan2] && [onchan $nick $pvchan2]} {
set pvmask2 "*!*$uhost"
#set pvmask "*!*@[lindex [split $uhost @] 1]"
if {![ischanban $pvmask2 $pvchan2]} {
set pvkickmsg2 "\002Msg Spam 30min. Ban!"
newchanban $pvchan2 $pvmask2 "Anti-Spam" $::pvkickmsg2 "%0d0h30m"

}
}
}
}

# cycle
timer $timecycle part_chan
proc part_chan {} {
global timecycle
foreach chancycle [channels] {
putserv "PART $chancycle :\037Spam Check!\037"
}
timer $timecycle part_chan
}
# SCRIPT ENDS

Changed the part which checks bot is opped. If the ban isn't set in the channel, the bot will set it within its internal ban list, once chanserv ops the bot, bot will ban the spammer with your message. The ban will last 30 minutes per your message.
_________________
speechles' eggdrop tcl archive

Last edited by speechles on Sat Jul 05, 2008 12:02 pm; edited 4 times in total

nml375
Revered One

Joined: 04 Aug 2006
Posts: 2857

Posted: Sat Jul 05, 2008 11:59 am Post subject:

speechles wrote:

nml375 wrote:

Binary OR is not the same as XOR (exclusive or)... The fundamental difference is when both expr1 and expr2 is true, with OR, this evaluates to True, while for XOR this evaluates to False. No language I've ever used does any kind of "magic" switch to XOR from OR...

Also, remember that tcl uses "lazy evaluation" of ||, &&, and ?: operations, meaning that as soon as there is no use for further tests, it'll skip on (ie. if the first test is true, and we are using ||, there is no need to do the second test since this can't change the outcome of it all...). Finally, >, <, <=, and >= has a far higher priority than ||...

Speechles wrote:

Quote:

* Parts: gather-lv (~gather@62.84.24.156) (Spam Check!)
* Joins: gather-lv (~gather@62.84.24.156)
* ChanServ sets mode: +o gather-lv

Here is your problem. The bot is not getting opped fast enough. It is spammed before it is opped. It will not do anything when spammed if not opped.

How do you gather that from this limited output? (that the bot is opped too slow) All I see is the bot parting (stating the custom reason "Spam Check!", rejoining, and being opped by chanserv... I do agree that the bot will do nothing if not opped, but I can see other reasons for this happening aswell..
_________________
NML_375, idling at #eggdrop@IrcNET

asdd1
Voice

Joined: 05 Jul 2008
Posts: 23

Posted: Sat Jul 05, 2008 12:00 pm Post subject:

asd Last edited by asdd1 on Sat Jul 05, 2008 1:41 pm; edited 1 time in total

nml375
Revered One

Joined: 04 Aug 2006
Posts: 2857

Posted: Sat Jul 05, 2008 12:08 pm Post subject:

asdd1 wrote:

Same, no changes.

To check i'm using this mIRC Script:

Code:

on 1:JOIN:#:/msg $nick join #test

<05.07 19:01:00> <gather-lv> [19:01] Tcl error [pv_kick2]: extra characters after close-brace
<05.07 19:01:00> <gather-lv> [19:01] [user01!test@84.237.152.149] join #test

Does your testing-client have ops or voice on the channels?
(seems speech' made a slight typo in his script, but I'm sure he'll post a fix shortly Smile

_________________
NML_375, idling at #eggdrop@IrcNET

asdd1
Voice

Joined: 05 Jul 2008
Posts: 23

Posted: Sat Jul 05, 2008 12:09 pm Post subject:

Nope.

asdd1
Voice

Joined: 05 Jul 2008
Posts: 23

Posted: Sat Jul 05, 2008 12:09 pm Post subject:

asd Last edited by asdd1 on Sat Jul 05, 2008 1:41 pm; edited 1 time in total

Display posts from previous:

	egghelp.org community Forum Index -> Scripting Help	All times are GMT - 4 Hours Goto page 1, 2, 3 Next
Page 1 of 3

You cannot post new topics in this forum
You cannot reply to topics in this forum
You cannot edit your posts in this forum
You cannot delete your posts in this forum
You cannot vote in polls in this forum