egghelp.org community

[psychic]

This is a part of my tcl which is not working and I get this error wrong # args: should be "putlog text"

[nml375]

That error is not related to the posted code. Look for some part of your script that contains putlog, as this is where the error most likely is located.

A few notes on the code in question however;
I see no reason for the use of the special argument "args". Especially since you only retrieve the first argument (lindex $args 0). Considder using something different, such as text.
Secondly, your use of lrange, as well as further use of lindex is flawed, as the "list" actually is a string. Please considder using split to convert the string to a list prior any list operations..

I will post a partial example on how you should use list commands, and how to implement the proc with normal arguments, rather than using the special "args".

[psychic]

I am afraid this didn't really help me much, I still can't do it.
All I wish to do is something like if { $cmd == "addban"} { newchanban $arg2 (host) $arg4 (duration in days) $arg3 (ban message) }

[nml375]

Still, none of those putlogs are responsible for that error of yours.. That error is elsewhere in your script.

=====

A quick rule of thumb, do not use the name "args" for any argument name in your procs. This is a special name, which has some extended features and caveats. Unless you are an advanced coder, you will have no use for those features, and the caveats are such that you need that [lindex $args 0] whenever you try to process the last argument.

Next, there are two fundamentally different data types in tcl. These are strings, and lists. Only use list-commands such as lindex, lrange, etc. on lists, never strings. If you need to "convert" a string into a list, use the command split. At the same time, don't use lists when a command expects a string.
_________________
NML_375, idling at #eggdrop@IrcNET

[psychic]

Alright, but can we focus a bit on the "newchanban" thingy? Can you tell me a correct syntax of using newchanban here? I mean in my code. ( I did change $args to a different name too)

[nml375]

Syntax for newchanban seems pretty much ok:
"newchanban <channel> <ban> <creator> <comment> ?lifetime? ?options?"

So, assuming arg2, arg3, and arg4 has been properly set, that part should work like a charm.
_________________
NML_375, idling at #eggdrop@IrcNET

[speechles]

[nml375]

Messing up lists and strings is indeed a problem within this script, but it will not cause the error mentioned in the original post. Regardless of the type of data, it's still one single parameter, so putlog would not complain 'bout number of parameters.
_________________
NML_375, idling at #eggdrop@IrcNET

[psychic]

Thanks all, I got it all working and much better now. Thanks to the guys on IRCNet #Eggdrop!

Thanks all!