egghelp.org community

[jeffo]

hi all,

as u've seen in the topic it's my first tcl one (did mirc scripts already).

here's my code so far:

[thommey]

1. bind pubm doesn't work that way, reread the documentation about it.. the mask is matched against "#chan text", not against "text"
   
2. $text isn't set in your proc, you called the last variable $rest
   
3. defining a proc in a proc is almost always wrong, you wouldn't do that in mircscript either, are you sure you know mircscript?
   
4. no need to "global myrand", a local variable is sufficient and better style if you store the return value of random_int
   
5. your if control structure seems to be weird, it generates the id only if !game is equal to $text but the rest is evaluated in any case
   
6. why not just .. "PRIVMSG #channel :$nick plays $myrand" instead of that spaghetticode?
   
7. you violate fundamental Tcl syntax with your elseif statements and your bracing style (brace = {})
   

In the end, my advice is to read a tcl tutorial, here's a list:

Tcl tutorials:

• http://www.invece.org/tclwise
  
• http://en.wikibooks.org/wiki/Programming:Tcl
  
• http://www.tcl.tk/man/tcl8.5/tutorial/tcltutorial.html
  
• http://wiki.tcl.tk/10259
  
• http://tcl.projectforum.com/young/22
  

Eggdrop specific:

• http://suninet.the-demon.de/
  
• http://johoho.eggheads.org/eggdrop/other/guide2tcl.html
  

I took the liberty of posting your "Tcl script" on a pastebin that has a static Tcl syntax checker and here you can see the result of that (the errors above the code): http://paste.tclhelp.net/?id=8p2

[jeffo]

yea, will do. ty, was trying to get my mirc script into tcl and as i've said i've never worked with tcl scripts, so u are right. but calling it "spaghetticode" is veeeery nice of u

[jeffo]

so...

[caesar]

If you want to trigger a command upon !game then you will need 'bind pub' not 'bind pubm'. By using 'pub' instead the:

[jeffo]

ty, will try it this way then. i thought the "rand()" is calling the function, but [rand 7] looks much more handy aswell as the "switch" cmd..

kudos

[caesar]

While in other coding languages it's rand() in TCL it's [rand]. Also, notice the [ and ] that translate in to calling the function of whatever you got inside.
_________________
Once the game is over, the king and the pawn go back in the same box.

[arfer]

In core Tcl it is the mathamatical expression rand(), used together with the command expr to return a random floating point value between 0 and 1.

The command [rand <limit>] only exists in Eggdrop Tcl to return a random integer between 0 and <limit>-1

Hence if you are scripting for Eggdrop, either is allowed.
_________________
I must have had nothing to do

[jeffo]

just another question for you pro's, would be cool if you could help me there. is it possible to set the trigger so that it will function (in this case) to not only "!game", but also to look in whole sentences like "why dont you type !game while we're at it"

i've tried:

bind pub -|- * !game game
bind pub -|- "* !game" game
bind pub -|- *!game* game
bind pub -|- "*!game*" game
bind pubm -|- "* !game" game
bind pubm -|- "% !game" game

and so on, but nothing works...

i.e. "*!game*" will trigger on *!game* only but not on "is this a !game"

[nml375]

Wildcards such as * and % only works with the matching version of the binding (such as pubm for public channel chat and msgm for private messages). The proper binding would in this case be as follows:

[jeffo]

yea, ty, but this pubm is messing the script up somehow, talking about the http://www.egghelp.org/cgi-bin/tcl_archive.tcl?mode=download&id=1689 by oldsoldier here, dunno what is wrong there

[nml375]

I can't see why the binding I proposed would interfere with bender_quotes, as they don't overlap.

If you were to apply the same kind of binding to the bender_quotes script however, you would have to rewrite the pub_bender proc as "arg" would contain the whole line of text (including the !game trigger), rather than the text following the first word.

With the simple scripts proposed in this thread, that wouldn't be an issue, since they don't care of the content of "text", though.
_________________
NML_375, idling at #eggdrop@IrcNET

[jeffo]

if i do pubm on it, it'll do

<..> <trigger>
-...- enter a number pitiful human! (notice)

the whole time, and only that

yea, trying to learn on the trigger thing, different script tho

[nml375]

So you were indeed applying the same kind of binding to the pub_bender proc. Thus, you'll either have to re-write pub_bender, or write a wrapper, to dig out the number from the whole line of text.
The simplest would probably be to write a wrapper, that actually don't bother with digging for the number, but use the random-line operation:

[jeffo]

ty, gonna try that