egghelp.org community

xREVx · Voice Joined: 25 Jul 2007 Posts: 15

oh i just thought you were gone, speechles. glad to hear from you!! Very Happy

in the mean time, here's a quick fix for google results:

add these lines below the code which the comment says "# added because of recent google changes, needed to clean-up *.google.* links":

Arkadietz · Posted: Sun Feb 05, 2012 3:52 pm Post subject:

10x a lot xREVx
_________________
On a unix system everything is a file ; if something is not a file , it is a proccess.

xREVx · Voice Joined: 25 Jul 2007 Posts: 15

np mate!

just added another line of code on my previous post, check it out Smile

tommytom · Voice Joined: 09 Sep 2011 Posts: 16

I wasn't having that problem, but I will add it anyways in case it comes up (can't stand when HTML is spewed all over IRC like that).

I need to get back to fixing these things. I was on 1.99 (and fixed it) for so long I still need to understand how this one works.

I really want weather working, but I did it the wrong way the last time. I meant to put more time up for this script myself but haven't, so I know where speechles is coming from.

tommytom · Voice Joined: 09 Sep 2011 Posts: 16

normal search fix
search for this around line 1647 (mine might vary)

Trixar_za · Op Joined: 18 Nov 2009 Posts: 143 Location: South Africa

The trouble with the replacement of class=r and class=g is that using ? like that only works with regex and not string matches (which uses glob). That could potentially break the script. The second probably is that some of the regex searches for the whole thing, so class="?r> wouldn't work, it needs to be class="?r"?>. Just a thought Wink

Well done on the rest of it through Smile

_________________
http://www.trixarian.net/Projects

tommytom · Voice Joined: 09 Sep 2011 Posts: 16

Yes, you are right. That's why I didn't do it. What I really meant was "add it manually/automatically to each properly", the properly was assumed and didn't check into it. I realized the "?r" situation later (I will go strike out my previous post).

You could probably build a regex s&r in certain editors, but that's still asking for trouble. If it ain't broke, don't fix it. I guess just add the "?r"? type stuff when it comes up (new one that changed and it got broken by this minuet problem).

Also, to add to the crap it would have broke doing a s&r, it would break class="r blah". Well, it would still match, but there is no need for the ? in there since it will always have quotes because of the space (AFAIK).

Sooooo many things broken still. "population of", "define:", "apple" (and others like it), etc. Seems like they are all falling into a "short answer" trap and only showing one result or none at all.

I put my old weather fix into my script just to have weather working (bit lackluster and I undo some stuff I shouldn't have, but I gotta learn how it is supposed to look.. no one has posted a log/ss for me to see).

Edit:
I revised it. And you are absolutely correct about the regular wildcard match string (glob?). I used class=r myself and didn't even think of this. Would have broken them.

tommytom · Voice Joined: 09 Sep 2011 Posts: 16

"more answers" fix

@line ~1426
Find this:

tommytom · Voice Joined: 09 Sep 2011 Posts: 16

I refixed the "time:" section in this post: http://forum.egghelp.org/viewtopic.php?p=98848#98848

Please recopy that part.
I left the stripping in (don't think it's needed) and put that last regsub back in and replaced it with the new regex that finds it.

Didn't realize at the time that the regsub is to strip the match criteria so that the next loop(s) will find the "long answer" search results (normal results, not answers).

Honestly, I think this is inefficient. Could you not set a $answerFound variable or something so that the second loop will not go into that section?

You could skip all the elseifs as well making the code more optimal.

Each regex/wildcard match update will only require updating that one line, not the regsub at the end as well to strip it. Each of those would just have "set answerFound 1" at the end and never have to edit that part again.

(psuedo code.. don't know TCL that well)

speechles · Posted: Fri Feb 24, 2012 11:49 pm Post subject:

spithash · Master Joined: 12 Jul 2007 Posts: 248 Location: Libera

speechles is right. this doesn't fix anything. it's just a mess up. it will only show the same result 3 times.

I don't want to be rude to anybody but, I will say this clearly: patience is gold.

there are reasons some things don't happen when we want them to happen. most of the time it means that if it happens when we want them to happen, disaster comes along. despite that we always, but always we have to double think.

why is this script one of the most wanted?
the answer is that because it's so awesome that everyone is using it.

another question is that, why don't we all let the coder himself fix it when he is ready? BECAUSE WE'RE ALLL TRYING TO STEAL SOME OF HIS GLORY/AND/OR RUIN THE SCRIPT. seriously, guys, I would never speak to you like this but it came to a point that nobody is patient to things that are nothing to us but a hobby

I wish I didn't offend anybody.

peace.

PS: I personally admire some people's efford on fixing stuff, but as speechles said, keep it out of here. hence this is the official thread for the script.
_________________
Libera ##rtlsdr & ##re - Nick: spithash
Click here for troll.tcl

nml375 · Revered One Joined: 04 Aug 2006 Posts: 2857

Moderated: Split from original thread UNOFFICIAL incith-google 2.0.0c (Sep9,2o11).

/NML_375
_________________
NML_375, idling at #eggdrop@IrcNET

tommytom · Voice Joined: 09 Sep 2011 Posts: 16

Man, you guys are pretty ungrateful.
Some guy tries to help fix things and you boot him out.

I guess I will just leech then.

I'm not fixing it perfectly, sure, but I am giving hotfixes for those that actually want the script to work (even partially), not 90-99% broken.

I don't see why you have a unreleased script if it is so perfect/better than my fixes. Kinda rude yourself to keep something like to yourself if it works.

Anyways, if anyone wants me to continue to share, PM or reply.
Doubt I will be back.

Edit: Thanks for the feedback on the duplicated results (didn't notice in my haste), but I still don't like the attitude. I would have made it better, but NVM.

xREVx · Voice Joined: 25 Jul 2007 Posts: 15

No need to walk away like that, tommytom. This is a forked thread so we should be allowed to do whatever we want here.

This could be the thread where people get fixes faster Wink

I'm grateful for what he has been doing, I've been using the script for quite a while now but I also agree he's pretty arrogant sometimes, and maybe because he thinks he's so great he's also too afraid of making mistakes, and that could be why he takes ages to release a fix...

I've shared my quick fix with the only intention of helping the community, because I thought it would be a bad attitude on my part if I kept the fix to myself while there are many others using the script and needing the fix.

Anyways, please keep doing it. Also, as a suggestion, maybe it'd be easier for everyone if you hosted the whole tcl file and just said what you've changed in it Smile

tommytom · Voice Joined: 09 Sep 2011 Posts: 16

Well, my fixes are experimental and only to get parts of it working. I have edited my copy so much, I will eventually have to take a clean copy and put my own fixes back in. I don't want to share this mangled copy I have.

I will make a fully edited beta script or something later maybe but my script has some custom bug fixes only for my editor (notepad++) that no one else would need.

Do you have a better suggestion for a syntax highlighting editor (not many for TCL, I'm sure)? notepad++ isn't that great (for TCL anyways). elseif isn't colored and unclosed regex quotes break the coloring (until another quote is found, the lines between are colorless as if the whole this is a quoted text). I currently have to add ;#" at the end of problem regex lines to fixes the lines after them.

I'm more of a utilitarian. I get it working, nothing more.
If I have to break a few things to get it working partially (over not at all), then I will. However, I don't want to turn that into a collection of these and call it some special script. If speechles wants to take my regexs or something to fix the main one "properly" without breaking the other languages (I don't care for that. We have google translate script(s) and mostly everyone speaks/reads English and 100% do in my channel). My goal was to get the important parts working, even partially, and speechles could take SOMETHING out of it if he hadn't fixed it already.

That said, if you want to take a clean copy (pre-fork), apply the fixes, and share it, then feel free. I really don't care. I'm fixing it for myself (and my channel) and posting how I did it. If someone has a better way of doing it, I don't care. Do it and share it if you like.