| View previous topic :: View next topic |
| Author |
Message |
swarfega Voice

Joined: 07 Oct 2006 Posts: 25
|
Posted: Thu Nov 01, 2012 12:54 pm Post subject: eggdrop 1.8 not logging channel chatter |
|
|
I have a recent build of eggdrop 1.8 and the most recent pisg stats.
I am trying to set up the bot so it logs all channel chatter so that it can be used with pisg. Currently its only logging joins, parts, quits, actions.
How can I fix this?
| Quote: | set max-logs 50
set max-logsize 2000
set quick-logs 0
set raw-log 0
logfile mcobxs * "logs/egglog/charlotte.log"
logfile jpk #blackoutgaming "logs/blackoutgaming/blackoutgaming.log"
set log-time 1
set timestamp-format {[%H:%M:%S]}
set keep-all-logs 1
set logfile-suffix ".%d%b%Y"
set switch-logfiles-at 000
set quiet-save 0
|
|
|
| Back to top |
|
 |
swarfega Voice

Joined: 07 Oct 2006 Posts: 25
|
Posted: Thu Nov 01, 2012 1:29 pm Post subject: |
|
|
I have found this in incith:google and wonder if its causing a conflict:
| Quote: | bind msgm -|- "*" incith::google::private_message
|
|
|
| Back to top |
|
 |
nml375 Revered One
Joined: 04 Aug 2006 Posts: 2857
|
Posted: Thu Nov 01, 2012 4:24 pm Post subject: |
|
|
An msgm-binding should not interfer with public (channel) chatter.
A pubm-binding however would prevent logging if the triggered code returns 1. _________________ NML_375, idling at #eggdrop@IrcNET |
|
| Back to top |
|
 |
swarfega Voice

Joined: 07 Oct 2006 Posts: 25
|
Posted: Fri Nov 02, 2012 5:09 pm Post subject: |
|
|
| That same script had one of those as well. So I decided to make a dedicated stats bot with no other scripts, which worked. |
|
| Back to top |
|
 |
speechles Revered One

Joined: 26 Aug 2006 Posts: 1398 Location: emerald triangle, california (coastal redwoods)
|
Posted: Sat Nov 03, 2012 12:13 am Post subject: |
|
|
Actually... It's because of the test platform I use. Everything is tested on windrop 1.6.17 at first.
| EGGDROP CHANGES - 1.6.18 wrote: | - Added support to MSGM, PUBM, NOTC, and WALL binds to support bound
procs returning 1 to prevent logging of the trigger message text. |
So now, yeah it has a return 1 where it should be a return 0. | Code: | | if {$::version < "1.6.18"} { return 1 } { return 0 } | Future versions of the script will include the code above to detect which value to return. The should fix the logging issue for all versions of eggdrop/windrop. _________________ speechles' eggdrop tcl archive |
|
| Back to top |
|
 |
nml375 Revered One
Joined: 04 Aug 2006 Posts: 2857
|
Posted: Sun Nov 04, 2012 9:20 am Post subject: |
|
|
speechles,
Just a question; is there any particular reason for returning 1 in the first place?
Also, your version-test would break on older eggdrops such as 1.6.9, since you are doing a string comparison. I'd rather recommend using numversion for this kind of test. _________________ NML_375, idling at #eggdrop@IrcNET |
|
| Back to top |
|
 |
speechles Revered One

Joined: 26 Aug 2006 Posts: 1398 Location: emerald triangle, california (coastal redwoods)
|
Posted: Mon Nov 05, 2012 11:30 pm Post subject: |
|
|
| nml375 wrote: | speechles,
Just a question; is there any particular reason for returning 1 in the first place? |
legacy. I wasn't the creator of this script (I've merely altered it unleashing it's strengths and turned on all the bells and whistles), the return 1 was incith's contribution (hence it still being named after him). In preserving as much of what he had as possible I've left it (this isn't speechles:google). It harms nothing having it there on an 1.6.17 eggdrop/windrop.
| nml375 wrote: | | Also, your version-test would break on older eggdrops such as 1.6.9, since you are doing a string comparison. I'd rather recommend using numversion for this kind of test. |
True, but in all honesty the script requires tcl8.4 or higher. Most bots compiled so long ago with 1.6.9 would need updating. But I do see your point and in the next release of this script your suggestion will be used. I was more into fixing it as quickly as possible and hadn't taken into account all the ramifications of the difference between the two. Now it is quite clear. Thanks for the advice.  _________________ speechles' eggdrop tcl archive |
|
| Back to top |
|
 |
neocharles Voice
Joined: 23 Apr 2013 Posts: 34
|
Posted: Sat Jul 20, 2013 11:03 pm Post subject: |
|
|
Is this fixed as of the current version? I am having issues with logging myself...
<edit>
I tried disabling nearly all the other tcl files, and my logs still aren't logging anything (jkp) that is said in the room.... Thoughts?
(Also realizing I'm running 1.6.21, not 1.8 ) |
|
| Back to top |
|
 |
|