egghelp.org community

Madalin · Posted: Wed Feb 20, 2013 7:09 am Post subject:

Try this

dirty · Halfop Joined: 08 Feb 2013 Posts: 40 Location: Romania

And maybe add some protection so that it won`t scan if someone uses !nmap without any $args

caesar · Posted: Wed Feb 20, 2013 9:42 am Post subject:

Public access to exec.. bad idea in the first place. Shocked

Not to mention the info exists progress will work for the first time, then will not allow the script to continue.

I think you meant to create an global variable outside the port_scan proc (after bind line, like set progress 0) then match it's value against 1 or 0 like if {$progress} or if {!$progress} and proceed with return or continue. Oh, and guys please refrain from using $args as has special meaning in TCL.
_________________
Once the game is over, the king and the pawn go back in the same box.

dirty · Halfop Joined: 08 Feb 2013 Posts: 40 Location: Romania

Not really caesar.. could be done this way..

speechles · Posted: Wed Feb 20, 2013 2:52 pm Post subject:

Caeser is right. An attacker can compromise your bot pretty immediately otherwise. For example, the code below:

dirty · Halfop Joined: 08 Feb 2013 Posts: 40 Location: Romania

Yes your right speachles and caesar.. but i only fixed the "info exists" and $args to $text part.. the part with exec can be fixed by checking $text for specific pattern or by limiting the command with a "bind pub n| !nmap port_scan"
_________________
come to the dark side.. I have cookies!
WwW.BotZone.TK

mimizu · Voice Joined: 20 Feb 2013 Posts: 7

I am trying to master ...

Wishing success ^ ^

Thank you very much before and after ....

mimizu · Voice Joined: 20 Feb 2013 Posts: 7

Sir...

If i use :

caesar · Posted: Thu Feb 21, 2013 2:09 am Post subject:

It's caesar damn it, also notice the lowercase Cool

Someone with bad intentions could compromise the box this is running, not just the bot. If you wish to check if a port is open or not, why not use one of user's scripts like socket api - nonblocking tcp made easy?

Or, if you wish to insist on using nmap, if there are certain arguments an user would use anyway why not add this modes inside the function and request user only for a valid IP adress? There are a few examples on Regular Expression Examples with a regexp or scan to do this IP validation.
_________________
Once the game is over, the king and the pawn go back in the same box.

mimizu · Voice Joined: 20 Feb 2013 Posts: 7

check port 1 by 1 x_x

nmap check all open and close port.... ^^

CMIWW

caesar · Posted: Thu Feb 21, 2013 10:41 am Post subject:

There's no need to quote the previous post if you intend to reply to that, and second, nmap dose exactly the same thing, except it already has a predefined list of ports to check so you just have to feed it with an IP address.
_________________
Once the game is over, the king and the pawn go back in the same box.