| View previous topic :: View next topic |
| Author |
Message |
DragnLord Owner

Joined: 24 Jan 2004 Posts: 711 Location: C'ville, Virginia, USA
|
Posted: Thu May 04, 2006 7:19 pm Post subject: * Bug Fix * |
|
|
| 3.6-a released to fix country code bug |
|
| Back to top |
|
 |
rosc2112 Revered One

Joined: 19 Feb 2006 Posts: 1454 Location: Northeast Pennsylvania
|
Posted: Fri May 05, 2006 3:19 am Post subject: teeny tiny fixes/suggestions |
|
|
Just a note to point out a typo or 2, and a suggestion.
In the top comments, you're still missing the [-s] option in the list, should be:
## Usage: .wz [-d] [-o] [-u imc] [-s][-t] [-p] [-short] [help] <city,state|zip> [country]
and further down, where -s is explained, sunset is spelled wrong =)
Also, some responses are sent by NOTICE, perhaps these should use the wz_msg_reply type that is defined? I usually change all the NOTICE to PRIVMSG to make it consistent (although it looks the same in my client, I don't use mirc
Once again and as always, thank you very much for keeping this script alive and doing a fine job  |
|
| Back to top |
|
 |
rosc2112 Revered One

Joined: 19 Feb 2006 Posts: 1454 Location: Northeast Pennsylvania
|
Posted: Fri May 05, 2006 3:27 am Post subject: oops, where's canada? =) |
|
|
| Ohh, I just noticed, canada is missing from the country list? Do we hate them for hockey, or for Anne Murray? <grin> |
|
| Back to top |
|
 |
cache Master
Joined: 10 Jan 2006 Posts: 306 Location: Mass
|
Posted: Fri May 05, 2006 3:58 am Post subject: |
|
|
Might be helpful if you go on Dragons server and show them.
First post states 'The script contains the channel and IRC network to report bugs and requests to.' |
|
| Back to top |
|
 |
rosc2112 Revered One

Joined: 19 Feb 2006 Posts: 1454 Location: Northeast Pennsylvania
|
Posted: Fri May 05, 2006 4:06 am Post subject: |
|
|
| Mea culpa |
|
| Back to top |
|
 |
DragnLord Owner

Joined: 24 Jan 2004 Posts: 711 Location: C'ville, Virginia, USA
|
Posted: Fri May 05, 2006 8:58 am Post subject: Canada |
|
|
Script updated, wrong list was included.
No version change. |
|
| Back to top |
|
 |
rosc2112 Revered One

Joined: 19 Feb 2006 Posts: 1454 Location: Northeast Pennsylvania
|
Posted: Fri May 05, 2006 9:59 pm Post subject: multiple matches prob? |
|
|
Well, I don't know if the bots on #weather @ shell-net does logging for submitting bug reports, and a written record here prolly won't hurt, so I'm posting this here as well =)
With the new additions to the ctlist/countries for australia, if I try to do like, !wz sydney au, it says there's multiple matches. Being that I'm american and we're stupid about geography, I don't know australia's regions and provinces, so perhaps the script should accept the 1st match of 'au' unless a more specific string is given, (eg, AU-SA)?
The change confused a few other people on the channel too, since we're used to using <cityname, au> |
|
| Back to top |
|
 |
DragnLord Owner

Joined: 24 Jan 2004 Posts: 711 Location: C'ville, Virginia, USA
|
Posted: Fri May 05, 2006 10:16 pm Post subject: |
|
|
just need to add an -exact to the match
for an easy fix, remove the listings with extended code for now |
|
| Back to top |
|
 |
Alchera Revered One

Joined: 11 Aug 2003 Posts: 3344 Location: Ballarat Victoria, Australia
|
Posted: Fri May 05, 2006 10:31 pm Post subject: |
|
|
| rosc2112 wrote: | | The change confused a few other people on the channel too, since we're used to using <cityname, au> |
| rosc2112 wrote: | | Being that I'm american and we're stupid about geography, I don't know australia's regions and provinces. |
NSW, VIC, ACT, SA, NT, QLD, WA & TAS (all States as we're a Federation).
Anyway, I am endeavouring to downgrade this script to a version that actually once worked! Last version to function correctly was weather3.5.9-a. _________________ Add [SOLVED] to the thread title if your issue has been.
Search | FAQ | RTM
Last edited by Alchera on Fri May 05, 2006 11:01 pm; edited 1 time in total |
|
| Back to top |
|
 |
DragnLord Owner

Joined: 24 Jan 2004 Posts: 711 Location: C'ville, Virginia, USA
|
Posted: Fri May 05, 2006 10:47 pm Post subject: |
|
|
| Alchera wrote: | | Quote: | <Almy> Sorry no matches for usa
<Almy> Sorry, us is not supported. Try !country <country> or /msg Almy !country <country> to find your 2 letter country code. |
|
"RTFM"  |
|
| Back to top |
|
 |
DragnLord Owner

Joined: 24 Jan 2004 Posts: 711 Location: C'ville, Virginia, USA
|
Posted: Fri May 05, 2006 10:54 pm Post subject: for those having trouble reading how to use the script |
|
|
| Code: | Usage: .wz [-d] [-o] [-u imc] [-t] [-p] [-short] [help] <city,state|zip> [country]
or /msg bot .wz [-d] [-o] [-u imc] [-t] [-p] [-short] <city,state|zip> [country]
state should be the two letter state code
country defaults to US and is not needed for US weather |
Don't complain that the use of "us" as a country code does not work, it's in the instructions not to use it. |
|
| Back to top |
|
 |
Alchera Revered One

Joined: 11 Aug 2003 Posts: 3344 Location: Ballarat Victoria, Australia
|
Posted: Fri May 05, 2006 11:02 pm Post subject: |
|
|
Read my *edited* post!
I am aware the script does not use "usa/us" even though wunderground.com apparently does.
I was part way through editing/posting when I got sidetracked re-testing last two script releases before settling on using 5.9-a (again); at least we can once more do:
.. etc  _________________ Add [SOLVED] to the thread title if your issue has been.
Search | FAQ | RTM
Last edited by Alchera on Fri May 05, 2006 11:10 pm; edited 1 time in total |
|
| Back to top |
|
 |
DragnLord Owner

Joined: 24 Jan 2004 Posts: 711 Location: C'ville, Virginia, USA
|
Posted: Fri May 05, 2006 11:05 pm Post subject: |
|
|
downgrade if you want to, new script has been posted for a while (before your post about "us" user errors)
3.6-b has no problems with Aussie requests. |
|
| Back to top |
|
 |
rosc2112 Revered One

Joined: 19 Feb 2006 Posts: 1454 Location: Northeast Pennsylvania
|
Posted: Fri May 05, 2006 11:33 pm Post subject: |
|
|
| DragnLord wrote: | just need to add an -exact to the match
for an easy fix, remove the listings with extended code for now |
I'm not sure where the -exact option would go, I only see one lsearch in the script and that already uses the -exact option. But in the meantime I did remove the extended codes. |
|
| Back to top |
|
 |
rosc2112 Revered One

Joined: 19 Feb 2006 Posts: 1454 Location: Northeast Pennsylvania
|
Posted: Fri May 05, 2006 11:37 pm Post subject: |
|
|
| Alchera wrote: |
NSW, VIC, ACT, SA, NT, QLD, WA & TAS (all States as we're a Federation).
|
Well, that doesn't tell me what cities are in which State.
| Alchera wrote: |
Anyway, I am endeavouring to downgrade this script to a version that actually once worked! Last version to function correctly was weather3.5.9-a. |
This version works, just have to remove the extra States/Regions for the moment. Or learn Oz geography I guess  |
|
| Back to top |
|
 |
|
|
You cannot post new topics in this forum You cannot reply to topics in this forum You cannot edit your posts in this forum You cannot delete your posts in this forum You cannot vote in polls in this forum
|
|